Py_DECREF for owned traceback and type objects

ijl · Jun 9, 2023 · 4550226 · 4550226
1 parent 18b6562
commit 4550226
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -259,6 +259,10 @@ fn raise_dumps_exception_dynamic(err: &String) -> *mut PyObject {
 
         if !cause_tp.is_null() {
             PyException_SetCause(val, cause_val);
+            Py_DECREF(cause_tp);
+        }
+        if !cause_traceback.is_null() {
+            Py_DECREF(cause_traceback);
         }
 
         PyErr_Restore(tp, val, traceback);

diff --git a/test/test_default.py b/test/test_default.py
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: (Apache-2.0 OR MIT)
 
+import sys
 import uuid
 
 import pytest
@@ -260,3 +261,17 @@ def default(obj):
 
         with pytest.raises(orjson.JSONEncodeError):
             orjson.dumps(ref, default=default)
+
+    def test_reference_cleanup_default(self):
+        """
+        references to encoded objects are cleaned up
+        """
+        ref = Custom()
+
+        def default(obj):
+            raise TypeError
+
+        with pytest.raises(orjson.JSONEncodeError):
+            orjson.dumps(ref, default=default)
+
+        assert sys.getrefcount(ref) == 2  # one for ref, one for default