From 855d34ce53b5b5d14cfcb854d4deeff71a88abc4 Mon Sep 17 00:00:00 2001 From: Isaac Lee <16869656+ijlee2@users.noreply.github.com> Date: Wed, 20 Dec 2023 16:58:42 +0100 Subject: [PATCH] Added ember-lts-5.4 to ember-try scenarios (#219) * chore: Allowed the latest Node 18.x * chore: Updated setup-node action to v4 * chore: Added ember-lts-5.4 scenario --------- Co-authored-by: ijlee2 --- .github/workflows/ci.yml | 13 +++++++------ test-app/config/ember-try.js | 8 ++++++++ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 26324109..415bf326 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,7 +7,7 @@ on: pull_request: env: - NODE_VERSION: 18.17 + NODE_VERSION: 18 PERCY_PARALLEL_NONCE: ${{ github.run_id }}-${{ github.run_number }} PERCY_PARALLEL_TOTAL: 9 @@ -32,7 +32,7 @@ jobs: version: latest - name: Use Node.js ${{ env.NODE_VERSION }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: cache: 'pnpm' node-version: ${{ env.NODE_VERSION }} @@ -59,7 +59,7 @@ jobs: version: latest - name: Use Node.js ${{ env.NODE_VERSION }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: cache: 'pnpm' node-version: ${{ env.NODE_VERSION }} @@ -124,7 +124,7 @@ jobs: version: latest - name: Use Node.js ${{ env.NODE_VERSION }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: cache: 'pnpm' node-version: ${{ env.NODE_VERSION }} @@ -167,7 +167,7 @@ jobs: version: latest - name: Use Node.js ${{ env.NODE_VERSION }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: cache: 'pnpm' node-version: ${{ env.NODE_VERSION }} @@ -190,6 +190,7 @@ jobs: - 'ember-lts-4.4' - 'ember-lts-4.8' - 'ember-lts-4.12' + - 'ember-lts-5.4' - 'ember-release' - 'ember-beta' - 'ember-canary' @@ -206,7 +207,7 @@ jobs: version: latest - name: Use Node.js ${{ env.NODE_VERSION }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: cache: 'pnpm' node-version: ${{ env.NODE_VERSION }} diff --git a/test-app/config/ember-try.js b/test-app/config/ember-try.js index 8f4a2038..c057cc27 100644 --- a/test-app/config/ember-try.js +++ b/test-app/config/ember-try.js @@ -36,6 +36,14 @@ module.exports = async function () { }, }, }, + { + name: 'ember-lts-5.4', + npm: { + devDependencies: { + 'ember-source': '~5.4.0', + }, + }, + }, { name: 'ember-release', npm: {