From b40c3fd8b4b12504c97e531a09d361c32875d3cb Mon Sep 17 00:00:00 2001
From: Jacqueline Nolis <jnolis@users.noreply.github.com>
Date: Sun, 5 Dec 2021 18:12:17 -0800
Subject: [PATCH 1/2] Added data-external

---
 R/service-box.R      | 3 ++-
 R/service-channel9.R | 3 ++-
 R/service-msstream.R | 3 ++-
 R/service-vimeo.R    | 3 ++-
 R/service-youtube.R  | 3 ++-
 5 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/R/service-box.R b/R/service-box.R
index 0fb4359..beb9bec 100644
--- a/R/service-box.R
+++ b/R/service-box.R
@@ -35,7 +35,8 @@ embed_box <- function(id, custom_domain = getOption("vembedr.box_custom_domain")
     frameborder = frameborder,
     allowfullscreen = allowfullscreen,
     webkitallowfullscreen = allowfullscreen,
-    msallowfullscreen = allowfullscreen
+    msallowfullscreen = allowfullscreen,
+    `data-external` = 1
   )
 
   embed <- create_embed(iframe, "vembedr_embed_box", ratio)
diff --git a/R/service-channel9.R b/R/service-channel9.R
index 036703e..c3d52d8 100644
--- a/R/service-channel9.R
+++ b/R/service-channel9.R
@@ -19,7 +19,8 @@ embed_channel9 <- function(id,
     width = dim$width,
     height = dim$height,
     frameborder = frameborder,
-    allowfullscreen = allowfullscreen
+    allowfullscreen = allowfullscreen,
+    `data-external` = 1
   )
 
   embed <- create_embed(iframe, "vembedr_embed_channel9", ratio)
diff --git a/R/service-msstream.R b/R/service-msstream.R
index 7d72bee..9ef71b5 100644
--- a/R/service-msstream.R
+++ b/R/service-msstream.R
@@ -17,7 +17,8 @@ embed_msstream <- function(id, width = NULL, height = 300,
     width = dim$width,
     height = dim$height,
     allowfullscreen = NULL,
-    style = "border:none;"
+    style = "border:none;",
+    `data-external` = 1
   )
 
   embed <- create_embed(iframe, "vembedr_embed_msstream", ratio)
diff --git a/R/service-vimeo.R b/R/service-vimeo.R
index b7ba5a2..d9eaccc 100644
--- a/R/service-vimeo.R
+++ b/R/service-vimeo.R
@@ -26,7 +26,8 @@ embed_vimeo <- function(id,
     frameborder = frameborder,
     webkitallowfullscreen = allowfullscreen,
     mozallowfullscreen = allowfullscreen,
-    allowfullscreen = allowfullscreen
+    allowfullscreen = allowfullscreen,
+    `data-external` = 1
   )
 
   embed <- create_embed(iframe, "vembedr_embed_vimeo", ratio)
diff --git a/R/service-youtube.R b/R/service-youtube.R
index d9d22ab..e0067fa 100644
--- a/R/service-youtube.R
+++ b/R/service-youtube.R
@@ -21,7 +21,8 @@ embed_youtube <- function(id,
     width = dim$width,
     height = dim$height,
     frameborder = frameborder,
-    allowfullscreen = allowfullscreen
+    allowfullscreen = allowfullscreen,
+    `data-external` = 1
   )
 
   embed <- create_embed(iframe, "vembedr_embed_youtube", ratio)

From 72b79ed9c068dc532465967338443caa3b4f7d97 Mon Sep 17 00:00:00 2001
From: Ian Lyttle <ian.lyttle@se.com>
Date: Mon, 6 Dec 2021 11:19:36 -0600
Subject: [PATCH 2/2] bump version, add to news

---
 DESCRIPTION | 2 +-
 NEWS.md     | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/DESCRIPTION b/DESCRIPTION
index 9583210..83f5cf1 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: vembedr
 Title: Embed Video in HTML
-Version: 0.1.4.9002
+Version: 0.1.4.9003
 Authors@R: c(
     person(
       given = "Ian", 
diff --git a/NEWS.md b/NEWS.md
index 8ad520e..3817c09 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,5 +1,7 @@
 # vembedr 0.1.4.9000 (development version)
 
+- updates `<iframe>` implementation to keep up with pandoc, see [rstudio/rmarkdown#2255](https://github.com/rstudio/rmarkdown/issues/2255) (#52,  @jnolis).
+
 - version bump for development
 
 ## vembedr 0.1.4
@@ -17,7 +19,7 @@
 
 ## vembedr 0.1.3
 
-- updates README to show some custom formatting (#25, thanks @koncina and @ginolhac)
+- updates README to show some custom formatting (#25, @koncina & @ginolhac)
 - deprecates `hms()` and `secs()` in favor of `use_start_time()` (#24)
 - adds function `embed_user2017()`: embed videos from UseR!2017
 - version bump for development