From eac286b9f16d81dd7b4d7ffd2a8a9f1d42dc9ab4 Mon Sep 17 00:00:00 2001 From: Saeed Rasooli Date: Mon, 2 Sep 2024 14:27:45 +0330 Subject: [PATCH] github test: use lxml==5.2 to fix jmdict test --- .github/workflows/test.yml | 2 +- tests/g_jmdict_test.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4184b3da6..113920008 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -35,7 +35,7 @@ jobs: beautifulsoup4 \ biplist html5lib \ python-idzip \ - lxml \ + lxml==5.2 \ marisa-trie \ mistune - name: Remove test cache diff --git a/tests/g_jmdict_test.py b/tests/g_jmdict_test.py index 28987136c..ee1e6c47b 100644 --- a/tests/g_jmdict_test.py +++ b/tests/g_jmdict_test.py @@ -23,6 +23,8 @@ def convert_jmdict_txt(self, fname, fname2, **convertArgs): **convertArgs, ) + # for some reason, with lxml==5.3.0, for "bword://{word}", `word` is not unicode-escaped by lxml + # while lxml < 5.3.0 does escape these unicode characters def test_convert_jmdict_txt_1(self): self.convert_jmdict_txt( "050-JMdict-English",