Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot minimize or maximize VSCode on Windows #140

Open
1 task done
codeAbinash opened this issue Apr 2, 2024 · 19 comments
Open
1 task done

[Bug] Cannot minimize or maximize VSCode on Windows #140

codeAbinash opened this issue Apr 2, 2024 · 19 comments
Labels
bug Something isn't working

Comments

@codeAbinash
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Cannot minimize or maximize window.

Expected Behavior

Minimizing or maximizing window should work.

Steps To Reproduce

Vibrancy Continued
v1.1.29

Environment

- OS: Windows 11
- VSCode: 1.87.2
- Extension: Vibrancy Continued v1.1.29
- Theme: One Dark Pro Darker

Anything else?

Rounded corners are also not available in window.

@codeAbinash codeAbinash added bug Something isn't working triage Cause of the issue needs to be triaged labels Apr 2, 2024
@illixion
Copy link
Owner

illixion commented Apr 2, 2024

Known issue due to breaking Electron 27 changes as mentioned in the description, currently no workaround besides downgrading VSCode to 1.85.2, will keep this issue open for future updates.

@illixion illixion removed the triage Cause of the issue needs to be triaged label Apr 2, 2024
@kanetjuh
Copy link

Even after downgrading VSCode to 1.85.2 the minimize/max- functionality still doesn't work!
image

@illixion illixion changed the title Cannot minimize or maximize window. [Bug] Cannot minimize or maximize VSCode on Windows Apr 16, 2024
@illixion illixion pinned this issue Apr 16, 2024
@FrankmDev
Copy link

Same error, any solution?

@avaneesh-pandey5
Copy link

I've uninstalled vibrancy continued but still can't use the maximize and minimize button, any fixes?

@emuel-vassallo
Copy link

emuel-vassallo commented May 5, 2024

I've uninstalled vibrancy continued but still can't use the maximize and minimize button, any fixes?

Install it again, run vscode as administrator, press F1 and click "Disable Vibrancy", and uninstall it.

@minecraftfen
Copy link

Same error on v1.89.1
image

@dustingleaton
Copy link

I've uninstalled vibrancy continued but still can't use the maximize and minimize button, any fixes?

Install it again, run vscode as administrator, press F1 and click "Disable Vibrancy", and uninstall it.

Life saver! This has worked for me!

@MrOxMasTer
Copy link

MrOxMasTer commented Jun 4, 2024

The same thing (1.89.1)

@illixion
Copy link
Owner

illixion commented Jun 4, 2024

Everyone on Windows with VSCode 1.86.0 and newer is currently experiencing this issue, no need to +1 unless you have something to add to the discussion.

As a reminder, Vibrancy needs to be reloaded after downgrading VSCode as mentioned earlier by another user.

@mikaib
Copy link

mikaib commented Jun 9, 2024

I am using FancyWM, and it seems like whatever bug is causing this is also causing FancyWM to not work. It cannot resize or move vscode.

@minecraftfen
Copy link

minecraftfen commented Jun 18, 2024

@kacwos

Everyone on Windows with VSCode 1.86.0 and newer is currently experiencing this issue, no need to +1 unless you have something to add to the discussion.

As a reminder, Vibrancy needs to be reloaded after downgrading VSCode as mentioned earlier by another user.

As illixion said, EVERYONE is currently experiencing this issue, so please do NOT comment when you cannot provide any information to help solve the problem.

When you comment, everyone who subscribed this issue will get a notification, if your comment can't help everyone, it will cause unnecessary disturbance.

@illixion
Copy link
Owner

How can I solve this problem so that vibrancy works but does not have this problem?

You need to downgrade to VSCode 1.85.2, which is clearly mentioned in the first reply in this thread and at the very top of Vibrancy’s description.

@ismail-elmokhfi
Copy link

ismail-elmokhfi commented Jun 26, 2024

Guys, after I pressed F1 and type "Disable Vibrancy" I uninstalled the extention, and I reinstalled the vs code, it worked

@Souvik0046
Copy link

I've uninstalled vibrancy continued but still can't use the maximize and minimize button, any fixes?

Install it again, run vscode as administrator, press F1 and click "Disable Vibrancy", and uninstall it.

Thanks a bunch brother. Saved my life

@prabeenragupathi
Copy link

I've uninstalled vibrancy continued but still can't use the maximize and minimize button, any fixes?

Install it again, run vscode as administrator, press F1 and click "Disable Vibrancy", and uninstall it.

It Worked very well !!

@JackBlaze132
Copy link

It's been 7 updates and this issue is still not fixed, if someone knows how minimize and maximize functions works, pls answers to this comment, so we can try to fix it and make a pull request

@illixion illixion mentioned this issue Sep 3, 2024
1 task
@koebelt
Copy link

koebelt commented Sep 10, 2024

It's been 7 updates and this issue is still not fixed, if someone knows how minimize and maximize functions works, pls answers to this comment, so we can try to fix it and make a pull request

It's indeed annoying. I just swiched to windows for work and being unable to snap VSCode is slowly getting me.

I quickly searched but cannot find anything related to window resizing in Electron 27 changelog
But its probably due to the fact that this plugin overrides the default behaviour of moving and resizing.
Line 33 : vscode-vibrancy-continued/blob/main/runtime/win10refresh.js :

/**
 * Unfortunately, we have to re-implement moving and resizing.
 * Enabling vibrancy slows down the window's event handling loop to the
 * point building a mouse event backlog. If you just handle these events
 * in the backlog without taking the time difference into consideration,
 * you end up with visible movement lag.
 * We tried pairing 'will-move' with 'move', but Electron actually sends the
 * 'move' events _before_ Windows actually commits to the operation. There's
 * likely some queuing going on that's getting backed up. This is not the case
 * with 'will-resize' and 'resize', which need to use the default behavior
 * for compatibility with soft DPI scaling.
 * The ideal rate of moving and resizing is based on the vertical sync
 * rate: if your display is only fully updating at 120 Hz, we shouldn't
 * be attempting to reset positions or sizes any faster than 120 Hz.
 * If we were doing this in a browser context, we would just use
 * requestAnimationFrame and call it a day. But we're not inside of a
 * browser context here, so we have to resort to clever hacks.
 * This VerticalRefreshRateContext maps a point in screen space to the
 * vertical sync rate of the display(s) actually handing that point.
 * It handles multiple displays with varying vertical sync rates,
 * and changes to the display configuration while this process is running.
 */

Is This workaround still necessarry ? It seems janky at best.

@illixion
Copy link
Owner

illixion commented Sep 11, 2024

@koebelt there is at least one person who reported that this fix was necessary for them: #52

There was also more discussion here about refactoring this fix: #38

@thegsu
Copy link

thegsu commented Nov 15, 2024

I've uninstalled vibrancy continued but still can't use the maximize and minimize button, any fixes?

Install it again, run vscode as administrator, press F1 and click "Disable Vibrancy", and uninstall it.

Really Helped Thank You so so much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

17 participants