Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Group 4 decoding with fax crate? #157

Closed
marknefedov opened this issue Mar 15, 2022 · 1 comment
Closed

Possible Group 4 decoding with fax crate? #157

marknefedov opened this issue Mar 15, 2022 · 1 comment

Comments

@marknefedov
Copy link

https://github.com/pdf-rs/fax
It looks like it can be possible to implement fax/group 4 compression.

@marknefedov marknefedov changed the title Possible Group 4 decoding with fax crate Possible Group 4 decoding with fax crate? Mar 15, 2022
@HeroicKatora
Copy link
Member

A few too many unwraps on user input instead of proper error handling to be considered for a default-on option, but otherwise looks promising. For example:

https://github.com/pdf-rs/fax/blob/master/src/decoder.rs#L64

I'd gladly consider a PR with binding anyways. For example, there shouldn't be an issue if users had to opt-in (as an optional feature and at runtime) to mark it as somewhat unstable. Many issues can be quickly found with fuzzer coverage as well—see this repository for an example. Also ping this issue from time-to-time as fax seems to be under development and this judgment may well change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants