Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code example #28

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Update code example #28

merged 1 commit into from
Jun 1, 2020

Conversation

urakozz
Copy link
Contributor

@urakozz urakozz commented Nov 24, 2019

No description provided.

djpowers
djpowers approved these changes Apr 7, 2020
View reviewed changes
Copy link

@djpowers djpowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see this PR merged in, as I was tripped up myself by the outdated documentation. Confirming that this change works, and that it fixes #23.

@AskingQuestions
Copy link

AskingQuestions commented May 26, 2020 •
edited
Loading

I was just about to PR this same issue. I can confirm it works.

This change was from 2016
imagemin/imagemin@06d0a03

@1000ch 1000ch merged commit 59dce34 into imagemin:master Jun 1, 2020
This was referenced Jun 1, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djpowers djpowers djpowers approved these changes

@1000ch 1000ch 1000ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@urakozz @AskingQuestions @1000ch @djpowers