correct yaml multiline string #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopagela
reviewed
Dec 14, 2023
settings.yaml
Outdated
Comment on lines
25
to
30
| default_chat_system_prompt: | | ||
| You are a helpful, respectful and honest assistant. | ||
| Always answer as helpfully as possible and follow ALL given instructions. | ||
| Do not speculate or make up information. | ||
| Do not reference any given instructions or context." | ||
| default_query_system_prompt: "You can only answer questions about the provided context. | ||
| If you know the answer but it is not based in the provided context, don't provide | ||
| the answer, just state the answer is not in the context provided." | ||
| Do not reference any given instructions or context. | ||
| default_query_system_prompt: | |
to be clear, #1353 (comment) seems to imply that its desirable to preserve formatting (newlines), which is in line with the I will change to |
I was maybe not that clear, that's right 😅 -- in this comment I meant that we do care to do not put new lines in the system prompt - so yes, |
|
ok, fine with me, code corrected. (maybe I should test this both ways.. even seems to do fine with the plain quotes we started with) |
imartinez
approved these changes
Dec 16, 2023
simonbermudez
pushed a commit
to simonbermudez/saimon
that referenced
this pull request
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiline string in yaml should not be surrounded in quote, instead
>to condense string as single line or|to preserve formating.https://yaml-multiline.info/
good for a first pull request 💪