Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Fix carbon issues #34

Closed
imdhemy opened this issue Mar 28, 2023 · 0 comments · Fixed by #35
Closed

[1.x] Fix carbon issues #34

imdhemy opened this issue Mar 28, 2023 · 0 comments · Fixed by #35
Assignees
@imdhemy

Comments

@imdhemy
Copy link
Owner

imdhemy commented Mar 28, 2023

Below is an example of a Carbon error on running tests

TypeError : Carbon\Carbon::setLastErrors(): Argument #1 ($lastErrors) must be of type array, bool given, called in /Users/imdhemy/code/google-play-billing/vendor/nesbot/carbon/src/Carbon/Traits/Creator.php on line 670
@imdhemy imdhemy converted this from a draft issue Mar 28, 2023
@imdhemy imdhemy self-assigned this Mar 28, 2023
@imdhemy imdhemy changed the title Fix carbon issues [1.x] Fix carbon issues Mar 28, 2023
@imdhemy imdhemy mentioned this issue Mar 28, 2023
Merged
@imdhemy imdhemy moved this from 📋 Backlog to 🏗 In progress in In-app purchase Mar 28, 2023
@imdhemy imdhemy moved this from 🏗 In progress to 👀 In review in In-app purchase Mar 28, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in In-app purchase Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imdhemy imdhemy

Labels
None yet
Projects
In-app purchase
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[1.x]: fix carbon errors imdhemy/google-play-billing
1 participant
@imdhemy