Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make element validation more precise #115

Open
ammarbarakat opened this issue Jan 19, 2023 · 0 comments · May be fixed by #116
Open

Make element validation more precise #115

ammarbarakat opened this issue Jan 19, 2023 · 0 comments · May be fixed by #116
Assignees

Comments

@ammarbarakat
Copy link
Contributor

ammarbarakat commented Jan 19, 2023

Describe your problem.

The element validation is not precise enough.
rules that are not included:

  1. number of definitions for a value domain should be at least 1.
  2. element urn should have the structure urn:namespaceIdentifier:elementType:elementIdentifier:elementRevision
  3. additionalProperties should not be allowed.
  4. status is required in every element identification
  5. a dataElement should include either the valueDomainUrn or the valueDomain (but not both at the same time)
  6. a valueDomain should include exactly one of "text", "datetime", "numeric"
  7. a valueDomain of type "datatime" should accept only one of these combinations: ["date"] ["date", "time", "hourFormat"] ["time", "hourFormat"]
  8. namespaceUrn is required for all elemnt types except NAMESPACE
  9. identification/hideNamespace is not allowed for DATAELEMENT, DATAELEMENTGROUP, RECORD, DESCRIBED_VALUE_DOMAIN, ENUMERATED_VALUE_DOMAIN, PERMISSIBLE_VALUE

Describe the solution you'd like

Add the described rules.

@ammarbarakat ammarbarakat self-assigned this Jan 19, 2023
ammarbarakat added a commit that referenced this issue Jan 19, 2023
- Add more validation rules
@ammarbarakat ammarbarakat linked a pull request Jan 19, 2023 that will close this issue
ammarbarakat added a commit that referenced this issue Jan 25, 2023
- Update namespaceUrn validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant