-
-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] fix: recursive issue with Draft and JSONTypes #990
Conversation
✅ Deploy Preview for quizzical-lovelace-dcbd6a canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, will merge!
Nice work! Thank you! |
🎉 This PR is included in version 9.0.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@mweststrate This PR does not properly fix the issue and introduces bugs in other scenarios (#1013). It should probably be reverted. |
* Add failing test * Revert #990
Thanks for reverting. The fix didn't take account for union type. Will see if I can make a proper fix for that later. Can we reopen #839? |
fixes #839
I have added test under
__tests__/types/type-externals.ts
.There are several things I have observed:
yarn build -> 'cp' is not recognized as an internal or external command
I think these should be fixed.
Here is an video about the details: https://www.youtube.com/watch?v=PCRzWIubAEQ