Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Galaxy S7 #3

Closed
AdrienPoupa opened this issue Jan 19, 2017 · 9 comments
Closed

Issue with Galaxy S7 #3

AdrienPoupa opened this issue Jan 19, 2017 · 9 comments
Assignees
Labels

Comments

@AdrienPoupa
Copy link

AdrienPoupa commented Jan 19, 2017

Hello,

First of all, thanks for creating this repo!

However, when I try to use your compiled version of Aframe (https://rawgit.com/thoragio/vr-aframe-dist/master/040/aframe-v0.4.0.min.js) with a Samsung Galaxy S7 the image is still distorded/duplicated in a cardboard, despite your additions.

http://btco-code.appspot.com/debug/screen_test.html returns

UA: Mozilla/5.0 (Linux; Android 6.0.1; SM-G935F Build/MMB29K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.91 Mobile Safari/537.36
computed resolution: 2560 x 1440
screen.width: 640
screen.height: 360
screen.availWidth: 640
screen.availHeight: 360
window.devicePixelRatio: 4

Is there anything that can be fixed?

Thank you!

@thoragio
Copy link
Contributor

Hi, you have the exact same phone as me! Did you clear the cache when you updated your app to use my compiled version of A-Frame? I've had to go into Settings > Privacy > Clear browsing data and then clear cached images and files or my app would still use the previous version of A-Frame.

@AdrienPoupa
Copy link
Author

Thanks for the reply. Unfortunately it didn't help. I'm using it to display the default a-sky.

@thoragio
Copy link
Contributor

thoragio commented Jan 19, 2017

Can you show me your code so I can try to replicate the problem?

@AdrienPoupa
Copy link
Author

It is located here: http://loc.diagamter.com/testcardboard.html

On my OnePlus One, everything works just fine, but the view with the S7 is distorted.

@thoragio
Copy link
Contributor

I tested the page and was getting an error in the DPDB loader. I made a slight modification to the DPDB online cache file. I've tested it and it seems to be working fine now. Please try on your side and let me know.

Also, follow the steps above to clear your cache so that you get the latest DPDB cache file that I have updated.

@thoragio thoragio self-assigned this Jan 19, 2017
@thoragio thoragio added the bug label Jan 19, 2017
@AdrienPoupa
Copy link
Author

AdrienPoupa commented Jan 20, 2017

Awesome, it works! Many thanks.

I've also tried with an iPhone 6S and the image looks fine until I enter VR mode. Then, the image looks blurry, I assume this is related to this? aframevr/aframe#2008 In this case, is there anything that I can do to help?

Otherwise, can I simply use the 0.3.2 version and your DPDB cache?

@thoragio
Copy link
Contributor

Great!

Yes, the blur is related to that other issue. If you have some experience dealing with npm packages, check out the end of the discussion thread for that issue thread to see if you have any ideas. I am going to take a look at it when I get a chance.

In the meantime, you can just replace the Google DPDB URL in the 0.3.2 version with the URL to my repo and it will work fine. Or just use the one I've just updated here: https://github.com/thoragio/vr-aframe-dist

The URL you can use is: https://rawgit.com/thoragio/vr-aframe-dist/master/032/aframe-v0.3.2.min.js

Let me know if you have any issues with it when you test it on your iPhone 6S.

@AdrienPoupa
Copy link
Author

Once again, thank you. I don't own an IPhone personally which makes it hard for me to debug but I'll let you know if I face any issue.

@thoragio
Copy link
Contributor

OK. Thanks again for flagging this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants