Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect device parameters on SM-G930F #273

Closed
neeh opened this issue Jul 25, 2017 · 8 comments
Closed

Incorrect device parameters on SM-G930F #273

neeh opened this issue Jul 25, 2017 · 8 comments
Labels

Comments

@neeh
Copy link

neeh commented Jul 25, 2017

We're having troubles with Samsung Galaxy S7 when using the polyfill.

As you can see on the following picture, the distortion is incorrect on this device :

webvr-polyfill-dbdp-smg930f


The device parameters reported by the DPDB, (be it local or remote) are :

{
    "type": "android",
    "rules": [
        {
            "mdmh": "samsung/*/SM-G930F/*"
        },
        {
            "ua": "SM-G930F"
        }
    ],
    "dpi": 576.6,
    "bw": 3,
    "ac": 1000
}

Which gives :

{
    width: 1920,
    height: 1080,
    widthMeters: 0.08457856399583766,
    heightMeters: 0.04757544224765869,
    bevelMeters: 0.003
}

Strangely, it works well when using default Android parameters :

webvr-polyfill-dpdb-default

{
    widthMeters: 0.110,
    heightMeters: 0.062,
    bevelMeters: 0.004
}

Is the DPDB entry for this device incorrect?

@jsantell
Copy link
Contributor

Thanks for reporting!

Added in #164 via @PixelPartner; ping @adaroseedwards, have you seen similar on Samsung Galaxy S7? Any ideas?

@neeh
Copy link
Author

neeh commented Jul 25, 2017

Thanks for the link @jsantell

I followed the instructions. From the Device Info app I have :

diagonal: 5.09 inches
width: 2.48 inches
height: 4.45 inches
DPI: 480
Actual DPI X: 435.42825
Actual DPI Y: 431.57477
(computed bevel: 0.0272)

My user agent is : Mozilla/5.0 (Linux; Android 7.0; SM-G930F Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.125 Mobile Safari/537.36

I checked width and height with a ruler infos are correct.

Seems like the DPI is wrong in the DPDB?

@jbreckmckye
Copy link

You should raise an issue here - https://github.com/WebVRRocks/webvr-polyfill-dpdb

@AdaRoseCannon
Copy link
Member

I had not seen this precise issue unfortunately my S7 died last week.

The only issue I had seen is when power saving mode is on and the resolution is reduced. If the resolution is less than maximum it will get an incorrect crop.

@fredsa fredsa added the bug label Aug 31, 2017
@fredsa
Copy link

fredsa commented Aug 31, 2017

Likely same issues as described in googlevr/gvr-unity-sdk#421

@ancientc
Copy link

ancientc commented Sep 7, 2017

The issue is still there with the newest update too on Samsung S7.
How shall I fix this?

@AlexanderStohr
Copy link

AlexanderStohr commented Sep 10, 2017

seeing a note on Google VR Settings all possibly beeing updated at end of month.

SM-G930F seems to be a problem for at least Andorid 7.0 update and maybe starting in at least April 2017. (there the user could select the offscreen resolution in three steps and this buffer was zoomed/interpolated to the screen. the default setting is the middle option (FullHD). maybe it was set this way for power saving reasons. maybe the prior setting was the somewhat higher native resolution o the display. dpi values for the frame buffer resolution will thus change - for whatever reason that will make VR applications sort of fail.) But some reports on this happening even with Android 6.x seem to be present as well.
Sometimes the situation seems to improve when Google VR Settings app is removed and the system gets rebooted.

@jsantell
Copy link
Contributor

Moving Samsung resolution handling to fix incorrect distortions to immersive-web/cardboard-vr-display#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants