Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axis and angle are confused with reloading in landscape mode #309

Closed
env3d opened this issue Mar 16, 2018 · 10 comments
Closed

axis and angle are confused with reloading in landscape mode #309

env3d opened this issue Mar 16, 2018 · 10 comments

Comments

@env3d
Copy link

env3d commented Mar 16, 2018

Description:
Additional Information:
  • webvr-polyfill version: 0.10.3
  • Browser name/version/release channel: Chrome M65
  • Operating System: Android
@jsantell
Copy link
Contributor

I see what the issue is. This is from the Chrome m65 specific fix which uses deviceorientation -- starting in landscape doesn't have the correct transformation. Thanks for reporting! I'll patch this tomorrow.

@env3d
Copy link
Author

env3d commented Mar 16, 2018

Thanks for looking into this. Could you also look at why the pose is not centering properly? Cheers!

@jsantell
Copy link
Contributor

Do you see that only in Chrome m65? I see an initial jump a second after magic window starts. Not sure what's up with that. For better or for worse, this code path is hot fix, only temporarily for Chrome m65 builds (due to #307)

@env3d
Copy link
Author

env3d commented Mar 16, 2018

Yes this only happens in m65. I uninstalled the upgrade and the problem went away.
I realized it's a hotfix but I have demos and product deployment coming up so the platform update may not make it in time. Thanks

@anssiko
Copy link

anssiko commented Mar 16, 2018

@jsantell, for the webvr-polyfill code path that uses the new Sensor APIs (shipping in https://github.com/immersive-web/webvr-polyfill/releases/tag/v0.10.3) you could define the screen coordinate system to be used:

let sensor = new RelativeOrientationSensor({frequency: 60, referenceFrame: "screen"});

When referenceFrame is set to "screen", the native implementation handles the transformation for you. We added this feature to the spec and implemented it in Chrome based on your earlier feedback. Hope you like it!

For the context, see immersive-web/cardboard-vr-display#10 (comment)

Edit: for feature detection story, see immersive-web/cardboard-vr-display#10 (comment)

@jsantell
Copy link
Contributor

Yes this only happens in m65. I uninstalled the upgrade and the problem went away.
I realized it's a hotfix but I have demos and product deployment coming up so the platform update may not make it in time. Thanks -- @env3d

The problem will go away without the patch, but then you're limited to only one axis of rotation due to Chrome m65 regression. Unsure if there'll be a platform update in m65 for the frequency issue.

@anssiko This sounds great! To clarify, Chrome m67 will have the feature detection, but the screen referenceFrame has been implemented since m65? Would it be safe to assume the reference frame works on future implementations, removing the custom transformations?

@jsantell
Copy link
Contributor

@env3d can you confirm if the patch here works for you? tested on all initial starting orientations and transitioning to the other orientations, Chrome m65 and Firefox/Android 58.0.2 immersive-web/cardboard-vr-display#20

@env3d
Copy link
Author

env3d commented Mar 16, 2018

Thanks @jsantell for fixing this so quickly. I'm out of office this morning but will check it once I'm back in. Cheers.

1 similar comment
@env3d
Copy link
Author

env3d commented Mar 16, 2018

Thanks @jsantell for fixing this so quickly. I'm out of office this morning but will check it once I'm back in. Cheers.

@jsantell
Copy link
Contributor

@env3d tried it some more and got a few other eyes on it, fixed the issue, thanks for reporting! released as v0.10.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants