-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
axis and angle are confused with reloading in landscape mode #309
Comments
I see what the issue is. This is from the Chrome m65 specific fix which uses deviceorientation -- starting in landscape doesn't have the correct transformation. Thanks for reporting! I'll patch this tomorrow. |
Thanks for looking into this. Could you also look at why the pose is not centering properly? Cheers! |
Do you see that only in Chrome m65? I see an initial jump a second after magic window starts. Not sure what's up with that. For better or for worse, this code path is hot fix, only temporarily for Chrome m65 builds (due to #307) |
Yes this only happens in m65. I uninstalled the upgrade and the problem went away. |
@jsantell, for the webvr-polyfill code path that uses the new Sensor APIs (shipping in https://github.com/immersive-web/webvr-polyfill/releases/tag/v0.10.3) you could define the screen coordinate system to be used:
When For the context, see immersive-web/cardboard-vr-display#10 (comment) Edit: for feature detection story, see immersive-web/cardboard-vr-display#10 (comment) |
The problem will go away without the patch, but then you're limited to only one axis of rotation due to Chrome m65 regression. Unsure if there'll be a platform update in m65 for the frequency issue. @anssiko This sounds great! To clarify, Chrome m67 will have the feature detection, but the |
@env3d can you confirm if the patch here works for you? tested on all initial starting orientations and transitioning to the other orientations, Chrome m65 and Firefox/Android 58.0.2 immersive-web/cardboard-vr-display#20 |
Thanks @jsantell for fixing this so quickly. I'm out of office this morning but will check it once I'm back in. Cheers. |
1 similar comment
Thanks @jsantell for fixing this so quickly. I'm out of office this morning but will check it once I'm back in. Cheers. |
Description:
Additional Information:
The text was updated successfully, but these errors were encountered: