You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've got some very confusing terminology here as well as some poorly defined state.
The events onvrdisplayactivate and onvrdisplaydeactivate imply that "active" is defined as "the VRDisplay should be presented to" (or not). But we also have activeVRDisplays, which implies that "active" means "is currently presenting." These are contradictory and should be resolve. I suggest defining a single definition of "active" and renaming accordingly.
If you miss the onvrdisplayactivate event, whether because it fired before your script was ready or because the display was active (i.e. "should be presented to") before the page loaded, there is no way to know whether you should request presentation. We already have isConnected and isPresenting (the other definition of "active"), shouldn't we also have an analogous property here? Could be isMounted or isActive or something like that. Or maybe rather than a boolean, there could be an enum value that matches theVRDisplayEventReason.
The text was updated successfully, but these errors were encountered:
We've got some very confusing terminology here as well as some poorly defined state.
The events
onvrdisplayactivate
andonvrdisplaydeactivate
imply that "active" is defined as "theVRDisplay
should be presented to" (or not). But we also haveactiveVRDisplays
, which implies that "active" means "is currently presenting." These are contradictory and should be resolve. I suggest defining a single definition of "active" and renaming accordingly.If you miss the
onvrdisplayactivate
event, whether because it fired before your script was ready or because the display was active (i.e. "should be presented to") before the page loaded, there is no way to know whether you should request presentation. We already haveisConnected
andisPresenting
(the other definition of "active"), shouldn't we also have an analogous property here? Could beisMounted
orisActive
or something like that. Or maybe rather than a boolean, there could be an enum value that matches theVRDisplayEventReason
.The text was updated successfully, but these errors were encountered: