Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of "active" #163

Closed
brianchirls opened this issue Dec 15, 2016 · 1 comment
Closed

Clarification of "active" #163

brianchirls opened this issue Dec 15, 2016 · 1 comment
Milestone

Comments

@brianchirls
Copy link

We've got some very confusing terminology here as well as some poorly defined state.

  1. The events onvrdisplayactivate and onvrdisplaydeactivate imply that "active" is defined as "the VRDisplay should be presented to" (or not). But we also have activeVRDisplays, which implies that "active" means "is currently presenting." These are contradictory and should be resolve. I suggest defining a single definition of "active" and renaming accordingly.

  2. If you miss the onvrdisplayactivate event, whether because it fired before your script was ready or because the display was active (i.e. "should be presented to") before the page loaded, there is no way to know whether you should request presentation. We already have isConnected and isPresenting (the other definition of "active"), shouldn't we also have an analogous property here? Could be isMounted or isActive or something like that. Or maybe rather than a boolean, there could be an enum value that matches theVRDisplayEventReason.

@toji
Copy link
Member

toji commented May 16, 2018

This issue was moved to immersive-web/webvr#12

@toji toji closed this as completed May 16, 2018
@cwilso cwilso modified the milestones: Spec-Complete for 1.0, 1.0 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants