Added support for angular and linear velocity #1181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Mar 12, 2021
| @@ -1689,12 +1689,19 @@ An {{XRPose}} describes a position and orientation in space relative to an {{XRS | |||
| <pre class="idl"> | |||
| [SecureContext, Exposed=Window] interface XRPose { | |||
| [SameObject] readonly attribute XRRigidTransform transform; | |||
| [SameObject] readonly attribute DOMPointReadOnly? linearVelocity; | |||
There was a problem hiding this comment.
"populate a pose" should be populating these somehow
There was a problem hiding this comment.
Thanks!
I couldn't find where that happened. I will update.
|
@Manishearth for some reason my pushes are not coming to this PR. I will recreate it. |
|
GitHub is somewhat down right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #619
Also silences a couple of bikeshed warnings.
Preview | Diff