[BUG] import/no-unused-modules does not work with import { name as otherName }

[ehmicky]

When using import { ... as ... } statements, import/no-unused-modules does not seem to properly work.

In the following example, test export is used, but it's still reported as not used:

$ eslint .
/home/ehmicky/no-unused-modules-bug/src/file.js
  1:1  error  exported declaration 'test' not used within other modules  import/no-unused-modules

✖ 1 problem (1 error, 0 warnings)

src/main.js:

import { test as testTwo } from './file.js'

src/file.js:

export const test = true

.eslintrc.json:

{
  "parserOptions": {
    "ecmaVersion": 2019,
    "sourceType": "module"
  },
  "plugins": ["import"],
  "rules": {
    "import/no-unused-modules": [
      2,
      {
        "unusedExports": true,
        "ignoreExports": ["src/main.js"]
      }
    ]
  }
}

package.json:

{
  "name": "no-unused-modules-bug",
  "version": "1.0.0",
  "dependencies": {},
  "devDependencies": {
    "eslint": "^5.16.0",
    "eslint-plugin-import": "^2.17.2"
  }
}

Note: removing the ignoreExports: ["src/main.js"] does not fix this issue.

[ljharb]

cc @rfermann

[ehmicky]

Thanks a lot for the quick response!

However it seems like this bug is still happening. If you publish a new version of this library, I can create a demo repository.

In the meantime, you should be able to re-create this bug by copying the files as described above.

[rfermann]

@ehmicky: a demo repo would be great.

[ehmicky]

Sure I can do that tomorrow morning (I'm off my laptop for the night).

The repo will use the latest published version though, so won't include your first fix. But if you manually edit the dependency, you should see that this fix does not modify the behavior unfortunately.

[ehmicky]

Demo repo: https://github.com/ehmicky/no-unused-modules-bug

[rfermann]

Thanks for the repo. As it turned out, I missed one piece of code 😅

[ehmicky]

It works, thanks @rfermann! 🎉