We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the rule no-internal-modules also prevent exporting the submodules of other modules. (currently it only prevents importing)
no-internal-modules
When no-internal-modules is set to error, here is what we have:
error
import { f } from "./modules/submodule" // error export { f } from "./modules/submodule" // no error
This is annoying because it breaks the idea that a folder decides what it makes available to the exterior, and therefore, everything is accessible.
For instance, one could have
module1/ private/ f.js module2/ hacked_f.js g.js
with
//hacked_f.js export { f } from "../module1/private/f" //g.js import { f } from "./hacked_f.js"
The text was updated successfully, but these errors were encountered:
This seems like a good thing to add - although it would have to be behind an option to avoid being semver-major.
Sorry, something went wrong.
9dfef28
Successfully merging a pull request may close this issue.
Proposition
Make the rule
no-internal-modules
also prevent exporting the submodules of other modules.(currently it only prevents importing)
Description of the problem
When
no-internal-modules
is set toerror
, here is what we have:This is annoying because it breaks the idea that a folder decides what it makes available to the exterior, and therefore, everything is accessible.
Example
For instance, one could have
with
The text was updated successfully, but these errors were encountered: