Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[max-dependencies]: new option 'ignoreTypeImports' #1843

Closed
rfermann opened this issue Jul 1, 2020 · 1 comment · Fixed by #1847
Closed

[max-dependencies]: new option 'ignoreTypeImports' #1843

rfermann opened this issue Jul 1, 2020 · 1 comment · Fixed by #1847

Comments

@rfermann
Copy link
Contributor

rfermann commented Jul 1, 2020

This rule aims to notify about potential code smell or a module doing too much based on the number of imported dependencies.

It doesn't differentiate between regular imports and type imports though. Type imports are neither indicating code smell nor do they indicate that a module is doing too much.

Therefore it might be good to implement a new option allowing or disallowing the consideration of type imports.

Note: this would only influence users of Typescript and Flow.

@ljharb
Copy link
Member

ljharb commented Jul 1, 2020

That seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants