v2.23 broke alphabetical sorting

[jeron-diovis]

This and this changes cause the following weird effect.

With imports like this:

import React from 'react'
import { BrowserRouter } from 'react-router-dom'
...

func mutateRanksToAlphabetize produces following groups:

{
  '0.8': [ 'react-value', 'react-router-dom-value' ],
  ...
}

Then this group gets sorted alphabetically, and obviously turns into [ 'react-router-dom-value', 'react-value' ]. While normally, 'react' < 'react-router-dom' === true.

So after updating to 2.23 I suddenly have warnings about wrong imports order all over the project .

Probably, you may just use | instead of - to separate importKind from importName?

[ljharb]

cc @grit96 / #2021 - could you take a look at this?

[geraintwhite]

Perhaps the change should be reverted for now. I will try to take a look at fixing it next week.

[ljharb]

That's a pretty major thing to revert, I'm hoping we can roll forward.

[geraintwhite]

I've created a fix in #2071 and added a test for the code in the OP