Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule proposal: Enforce empty line below imports #244

Closed
sindresorhus opened this issue Apr 17, 2016 · 2 comments
Closed

Rule proposal: Enforce empty line below imports #244

sindresorhus opened this issue Apr 17, 2016 · 2 comments
Milestone

Comments

@sindresorhus
Copy link

I'm aware this is purely stylistic, but thought I'd propose it since it seems this plugin will soon expand to stylistic rules with the adoption of https://github.com/jfmengels/eslint-plugin-import-order

Fail

import foo from 'foo';
import bar from 'bar';
const unicorn = true;
const foo = require('foo');
const bar = require('bar');
const unicorn = true;

Pass

import foo from 'foo';
import bar from 'bar';

const unicorn = true;
const foo = require('foo');
const bar = require('bar');

const unicorn = true;

// @jamestalmage @jfmengels

@benmosher
Copy link
Member

Sounds good to me, will accept a PR.

@benmosher benmosher added this to the next milestone Apr 29, 2016
@benmosher
Copy link
Member

Oh weird, expected #245 to close this but I guess it didn't mention it explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants