Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition to rule: import/no-duplicates #2470

Closed
snewcomer opened this issue Jun 4, 2022 · 4 comments · Fixed by #2475
Closed

addition to rule: import/no-duplicates #2470

snewcomer opened this issue Jun 4, 2022 · 4 comments · Fixed by #2475

Comments

@snewcomer
Copy link
Contributor

The proposal here is to improve this rule and handle inline type modifiers

import { type Foo } from 'T';
import { type Bar } from 'T';
//^^^^^^^^^^^^^^^^^^^^ Error: duplicate import from module 'T' (import/no-duplicates)

Fixer

import { type Foo,  type Bar } from 'T';

ref #2469 and typescript-eslint/typescript-eslint#5050 (comment)

@ljharb
Copy link
Member

ljharb commented Jun 5, 2022

I absolutely agree this should be autofixable by no-duplicates.

@nerdjfpb
Copy link

nerdjfpb commented Jun 6, 2022

I'm new to the codebase, but can I take this issue?

@snewcomer
Copy link
Contributor Author

@nerdjfpb Happy if you did! If you don't happen to get to it by this weekend, I'll plan on jumping in.

@nerdjfpb
Copy link

nerdjfpb commented Jun 8, 2022

Some personal issue came up and I don't think I can jump on this in next 1/2 week. I think you can start working on this @snewcomer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants