Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-deprecated TomDoc support #302

Closed
josh opened this issue May 3, 2016 · 2 comments
Closed

no-deprecated TomDoc support #302

josh opened this issue May 3, 2016 · 2 comments

Comments

@josh
Copy link
Contributor

josh commented May 3, 2016

I know no-deprecated is still a WIP, but I was wondering if you'd consider parsing TomDoc Deprecated: annotations?

Its basically a line like:

// Deprecated: Resize an object to the given dimensions.

I'd totally be willing to code up a PR, just wanted to check if you'd consider this in scope.

Thanks!

@benmosher
Copy link
Member

I'm up for more flavors of docstring parsing, for sure. I'm not sure exactly how to work it in, though.

Naïvely, I can imagine some { flavor: 'tomdoc' } rule option where tomdoc is a doctrine-compatible docstring parser, though that's probably not practical as doctrine is pretty heavily JSDoc-influenced. (for good reason).

How would you propose to integrate it?

@josh
Copy link
Contributor Author

josh commented May 3, 2016

where tomdoc is a doctrine-compatible docstring parser

If you wouldn't mind embedding a tiny parser function into the file, it'd probably be really short. TomDoc is less structured than JSDoc. We could probably just scan for /Deprecated:/ and return it as { tags: [ "deprecated", ... ] } so it aligns with the doctrine result object.

There is a more legit tomdoc parser on npm, but I don't know if its worth adding another dependency just for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants