Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg-up vs read-pkg-up. #675

Closed
wtgtybhertgeghgtwtg opened this issue Nov 23, 2016 · 1 comment
Closed

pkg-up vs read-pkg-up. #675

wtgtybhertgeghgtwtg opened this issue Nov 23, 2016 · 1 comment
Labels
accepted enhancement semver-minor

Comments

@wtgtybhertgeghgtwtg
Copy link
Contributor

pkg-up is used to find the filepath of the nearest package.json. That filepath is then used to read that package.json. Could pkg-up be replaced with read-pkg-up? Both packages are written by the same author, but read-pkg-up reads the package.json and seems to be more maintained.
I can submit a Pull Request if you would like.
@benmosher
Copy link
Member

Hmmm, I thought I remembered the path to the package.json being used beyond just reading the file, but a quick search of the repo suggests otherwise.

Wouldn't hurt. PR away, thank for the tip! 😄

@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg mentioned this issue Nov 28, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted enhancement semver-minor
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benmosher @wtgtybhertgeghgtwtg