Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESlint v4 #870

Closed
KoltesDigital opened this issue Jun 12, 2017 · 6 comments · Fixed by #871
Closed

ESlint v4 #870

KoltesDigital opened this issue Jun 12, 2017 · 6 comments · Fixed by #871

Comments

@KoltesDigital
Copy link

Hi! Today is the official release of eslint v4.0.0. eslint --init can break because eslint-plugin-import only support eslint v3.x.

? How would you like to configure ESLint? Use a popular style guide
? Which style guide do you want to follow? Standard
? What format do you want your config file to be in? YAML
Local ESLint installation not found.
Installing eslint, eslint-plugin-standard, eslint-plugin-promise, eslint-config-standard
...
├─┬ eslint@4.0.0
├── UNMET PEER DEPENDENCY eslint-plugin-import@>=2.2.0
@ljharb
Copy link
Member

ljharb commented Jun 12, 2017

This is an open issue with eslint --init, not something this plugin needs to address.

That said, it'd be nice if it could publish a version that supports both v3 and v4. A PR would be helpful.

@brettz9
Copy link
Contributor

brettz9 commented Jun 20, 2017

Can't this line just be updated to include 4.0 (if not also this one)?

@brettz9
Copy link
Contributor

brettz9 commented Jun 20, 2017

After updating to ESLint 4, I'm getting the same unmet peer dependency error in attempting to shrinkwrap our package.

A very easy change was made for another ESLint plug-in. I could prepare a PR, but the change ought to be trivial for anyone with access.

@ljharb
Copy link
Member

ljharb commented Jun 20, 2017

@brettz9 it's not necessarily easy; but we also already have an open PR (#871).

@benmosher
Copy link
Member

I'll publish in the morning as 2.6.0

@benmosher
Copy link
Member

published 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants