Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isomorphic-ws for websocket transport #221

Closed
bcho opened this issue Aug 15, 2018 · 2 comments
Closed

Use isomorphic-ws for websocket transport #221

bcho opened this issue Aug 15, 2018 · 2 comments
Labels
question

Comments

@bcho
Copy link

bcho commented Aug 15, 2018

Currently, websocket transports is referencing a global WebSocket constructor, which works on browser. But can we add isomorphic-ws and enable usage in node side?
@johanbrandhorst
Copy link
Contributor

I think with #204 it looks like we'll want to be moving away from supporting Node (not an official decision!), so I don't see us making this change anytime soon. There is an official implementation of gRPC for Node already.

@easyCZ
Copy link
Contributor

easyCZ commented Feb 5, 2019

This is no longer relevant given the split of the transports.

@easyCZ easyCZ closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@easyCZ @bcho @johanbrandhorst