Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query: metric autocomplete drop down inserts wrong metric #1271

Closed
jjneely opened this issue Jun 21, 2019 · 5 comments
Closed

query: metric autocomplete drop down inserts wrong metric #1271

jjneely opened this issue Jun 21, 2019 · 5 comments

Comments

@jjneely
Copy link
Contributor

jjneely commented Jun 21, 2019

Thanos, Prometheus and Golang version used

Thanos v0.5.0
Go: go1.12.6

What happened

When working with the Graph UI from the Query web interface, the PromQL entry textarea will suggest metric names after you type in several letters.

For example, typing in "node_memory" (presuming node-exporter metrics are scraped somewhere) will produce a drop down with many/all possible completions. Selecting one fills in that completed metric name in the PromQL textarea.

However, (hard to show in pictures) if you have a long list of results and scroll or use PageDown to find the right metric, selecting that metric will insert a different metric name in the textarea. Not the metric name that was selected.

What you expected to happen

The metric selected should be inserted into the PromQL text area.

How to reproduce it (as minimally and precisely as possible):

In the PromQL text area type in "node_", scroll or PageDown to find a suggested metric toward the bottom of the list. Select it. Note that a different metric may have been inserted.

@jjneely
Copy link
Contributor Author

jjneely commented Jun 21, 2019

I think this is a Prometheus bug, and we just import the code. Ugh.

@bwplotka
Copy link
Member

)): Worth to put this bug on Prometheus then?

Thanks for spotting - must be quite annoying.

@jojohappy
Copy link
Member

Hi, I'm interested in this problem. Let me try to reproduce it both of thanos and Prometheus.

@jojohappy
Copy link
Member

@jjneely @bwplotka I have deep dive into the code of typeahead, I guess that it is a bug on the Bootstrap-3-Typeahead, meanwhile, it would be fine in Firefox 67.0.4 and Safari 12.1.1 in my laptop, but Chrome 74.0.3729.169 would hit the bug ): , I have submitted a issue and will wait for response. So you can use Firefox or Safari instead.

@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 11, 2020
@stale stale bot closed this as completed Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants