You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it would be interesting to have a flag for enabling/disabling the conversion from the generated CommonJS code to AMD. On my project I'm currently using a copy of the defs.bzl file, removing the call to _convert_js_files_to_amd_modules for this plugin to work for a React Native scenario.
Thoughts?
The text was updated successfully, but these errors were encountered:
pbsf
changed the title
Flag for enabling/disabling conversion from JS to AMD step.
Add a bazel flag for enabling/disabling conversion from JS to AMD step.
May 22, 2019
pbsf
changed the title
Add a bazel flag for enabling/disabling conversion from JS to AMD step.
Add a bazel flag for enabling/disabling conversion from CommonJS to AMD step.
May 24, 2019
I'm after something similar, as we need to take the generated protos into rollup_bundle.
I don't think a flag is the correct approach here though, as it's normally down to the downstream rule to request the right output (AMD, es6 etc) rather than the user passing in a flag.
I've been experimenting producing both es5 and es6 sources, instead of setting the es5 output to both:
I think it would be interesting to have a flag for enabling/disabling the conversion from the generated CommonJS code to AMD. On my project I'm currently using a copy of the
defs.bzl
file, removing the call to _convert_js_files_to_amd_modules for this plugin to work for a React Native scenario.Thoughts?
The text was updated successfully, but these errors were encountered: