Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No mail attachments when Opt-In is active and DB saving is disabled #1185

Open
599media opened this issue Nov 15, 2024 · 0 comments
Open

No mail attachments when Opt-In is active and DB saving is disabled #1185

599media opened this issue Nov 15, 2024 · 0 comments

Comments

@599media
Copy link

599media commented Nov 15, 2024

In powermail 12.5 (actually since b01275d) the sent mail does not contain attachments when opt-in is active and db saving is disabled.

The problem is, that the actual mail is deleted before mail had been sent (see https://github.com/in2code-de/powermail/blob/typo3-v12/Classes/Controller/FormController.php#L460-L464). It's no problem for the mail content directly attached to the $mail object, but the attachments for the mail are received by fillFilesFromExistingMail function of the UploadService (see https://github.com/in2code-de/powermail/blob/typo3-v12/Classes/Domain/Service/UploadService.php#L222-L251). Since the mail does not exist anymore, the repository cannot return the mail in https://github.com/in2code-de/powermail/blob/typo3-v12/Classes/Domain/Service/UploadService.php#L228.

Maybe the mail deletion should be handled in the createAction after the mail had been sent after opt-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant