Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expansive terms #430

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Expansive terms #430

merged 5 commits into from
Mar 19, 2024

Conversation

loarie
Copy link
Member

@loarie loarie commented Mar 19, 2024

added term_id_or_unknown annotation. Not sure why I'm getting eslint errors from CI

@loarie loarie requested a review from pleary March 19, 2024 06:57
@pleary
Copy link
Member

pleary commented Mar 19, 2024

The eslint validation errors should be displayed in the "Files changed" view of this PR, but I find that view too jumbled. They are also listed if you expand the Run npm run eslint section of the test run https://github.com/inaturalist/iNaturalistAPI/actions/runs/8338802493/job/22819712785 . Things appear to be working as intended, but I think there are some unneeded query clauses. I made an attempt to simplify how these new parameters work and made a PR for that to merge into your branch #431. Some shared filters were extracted into methods, and the filters for new queries minimized

@loarie
Copy link
Member Author

loarie commented Mar 19, 2024

thanks, this looks good on staging. Let me know when you approve merging in this and the related inaturalist/inaturalist#4055

@pleary pleary merged commit ddb5e36 into main Mar 19, 2024
6 checks passed
@pleary pleary deleted the expansive-terms branch March 19, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants