fix: obs search reqs w/ spatial params should not return cached data #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kueda
changed the title
pleary
reviewed
Sep 15, 2024
| @@ -491,16 +491,12 @@ const util = class util { | |||
| if ( queryDup.order_by === "" ) { | |||
| delete queryDup.order_by; | |||
| } | |||
| if ( _.isEmpty( queryDup.lat ) && _.isEmpty( queryDup.lat ) ) { | |||
There was a problem hiding this comment.
I believe the root cause of the new symptom is that for v2, parameters are coerced into their defined data type and not all strings coming from the request parameter string as is the case with v1. The lodash _.isEmpty method considers numbers to be empty, resulting in v2 requests with lat/lng having their lat/lng ignored when generating a cache key. All else looks good, so I'll merge this but might restore this bit adding in an additional check of && !_.isNumber
pleary
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symptom was that iNat Next was showing global results in Explore when it should have been showing Nearby... sometimes and not others.
I'm not sure if this is actually what we want (no caching for these params), but this will fix the bug. If we do want caching with those params, that wasn't working either, but it's a simple fix.