Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Git sha in application #98

Closed
TheJenne18 opened this issue Apr 24, 2024 · 1 comment · Fixed by #107
Closed

[Enhancement] Git sha in application #98

TheJenne18 opened this issue Apr 24, 2024 · 1 comment · Fixed by #107
Assignees
@TheJenne18
Labels
enhancement Improvement of existing code

Comments

@TheJenne18
Copy link
Contributor

system(command = 'powershell "docker build --build-arg GIT_SHA=$(git rev-parse HEAD) -t inbo/alienspecies ."')
@TheJenne18 TheJenne18 added the enhancement Improvement of existing code label Apr 24, 2024
@TheJenne18 TheJenne18 self-assigned this Apr 24, 2024
@SanderDevisscher SanderDevisscher mentioned this issue May 30, 2024
Merged
@mvarewyck
Copy link
Collaborator

@TheJenne18 Could you please implement this change? If already done, sth still goes wrong as the env variable GIT_SHA doesn't get through in the app.

@TheJenne18 TheJenne18 linked a pull request Jul 19, 2024 that will close this issue
👷 Pass git commit hash to docker build #107
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheJenne18 TheJenne18

Labels
enhancement Improvement of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

👷 Pass git commit hash to docker build inbo/alien-species-portal
2 participants
@TheJenne18 @mvarewyck