-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#12): add otel service name as an input or env var #13
feat(#12): add otel service name as an input or env var #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a test case that validates the service name. You should be able to add the the test in trace.test.ts
under the "resource attributes" test suite for a test case of "has service.name resource as otelServiceName" or something like that.
Thanks for the contribution @pragmaticivan! I left a couple of comments. After those changes i think this will be good to merge in. |
77faf43
to
0c58ae7
Compare
Updated @nikordaris thanks! |
@nikordaris anything I need to fix? I just did run lint and test locally and they are all working. |
I've just updated my node version to exactly the one used in the CI (which uses latest and will probably come with unexpected side effects). By changing the |
@pragmaticivan ok, i think i fixed the build issues. if you pull the latest from main it should fix the build for this PR. apparently node 16.16 is stricter on version conflicts than 16.13 |
0c58ae7
to
9f63133
Compare
@nikordaris rebased from the |
Ok the update dist action wasn't designed for forks. I need to fix that. |
@pragmaticivan ok i think i resolved the build issues. it looks like it created conflicts for you though. if you pull the latest, hopefully that will fix the build |
8bc9330
to
ec96fbf
Compare
@nikordaris rebased |
fixes #12
ref: https://github.com/open-telemetry/opentelemetry-specification/blob/f124b21de091f3d668e4ce11b954ec17e3da231f/specification/sdk-environment-variables.md#general-sdk-configuration