Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to ignore already started error #312

Closed
longquanzheng opened this issue Jul 28, 2023 · 0 comments · Fixed by #468
Closed

Options to ignore already started error #312

longquanzheng opened this issue Jul 28, 2023 · 0 comments · Fixed by #468
Assignees
Labels
enhancement New feature or request in-review Learning small but useful small

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Jul 28, 2023

It's been a common pattern to ignore AlreadyStartedError.

See example in Temporal Golang SDK's StartWorkflowOptions

Implementation idea:

  • Option 1: pass in the ignore as a flag in the start request. So that the server will respond 200 status. (preferred)
  • Option 2: Alternatively, doing it only in SDK is also fine. But server will respond 400 status today, which will look a bit annoying.

Another big reason for option 1 is that we can support passing in a idempotent key(uuid) to dedup(already supported in cadence temporal). Only throw error if the key not match.

This dedup key is super useful for case like parent starts child workflows from a channel message. Where msg can be duplicated. It can use state execution id as dedup key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-review Learning small but useful small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants