Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize executingStateIdMode of ENABLED_FOR_STATES_WITH_WAIT_UNTIL and ENABLED_FOR_ALL #454

Closed
longquanzheng opened this issue Oct 16, 2024 · 0 comments
Assignees

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Oct 16, 2024

Check if the next state is also wait until, then skip a upsertSearchAttribute as clearing up for the current one(because the next one will be upserting )

Note: this will need a new version after #453 if not built within.

Similarly, we could do the same thing for ENABLED_FOR_ALL -- we can check whether or not it has a next state.

Also, if there is no changes to the StateIds, do not call the UpsertSearchAttribute API

Also make sure the state failed case is covered

@longquanzheng longquanzheng changed the title Optimize executingStateIdMode of ENABLED_FOR_STATES_WITH_WAIT_UNTIL Optimize executingStateIdMode of ENABLED_FOR_STATES_WITH_WAIT_UNTIL and ENABLED_FOR_ALL Oct 17, 2024
@lwolczynski lwolczynski self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants