-
Notifications
You must be signed in to change notification settings - Fork 38
Use conditional requests to avoid rate limiting problems #44
Comments
Hi, @danisyellis I would like to take up this task as my first contribution. It would be great to learn something out of it |
Hi @rajaSahil That would be fantastic. |
Hi @rajaSahil I just wanted to let you know that I'm doing virtual "office hours" tomorrow (maybe today when you read this) October 14th at 4pm PST https://organize.mlh.io/participants/events/5666-virtual-starfish-office-hours. And then again on October 26th from 2-3pm PST. https://organize.mlh.io/participants/events/5668-virtual-starfish-office-hours |
Thanks, @danisyellis I will try to join the virtual office, although it will be early morning here(4:30 am). |
Oof, that's really early! We can also set up some other time that works better for each of our timezones! |
Yes, that would be really helpful. |
Hi @rajaSahil are you still interested in working on this? If not, I'll unassign you. |
@danisyellis Can I work on this task? I would be the first one in my open source journey. So please assign it to me if possible. |
Hi @shehriyarnadeem. I will assign it to you. The primary maintainer (Dani) is unavailable right now, but I can try to help with any questions you might have. In particular, I encourage you to outline what solution you are going to try, to ensure that it will meet the requirements. When I tried the earlier docs link, it didn't seem to take me to a relevant section. I found this, which might be helpful, although I only took a quick glance at it: https://docs.github.com/en/rest/overview/resources-in-the-rest-api#conditional-requests |
See this link for more info conditional requests: https://developer.github.com/v3/#conditional-requests
We could use either ETags or the If-Modified-Since header.
Making a conditional request and receiving a 304 response does not count against our rate limit, so it could help any rate limiting issues.
We (at Indeed) haven't seen a huge problem with this, but a larger org almost certainly would.
The text was updated successfully, but these errors were encountered: