-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add arginfo for all functions #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility with PHP 8
Reflection:
|
remicollet
changed the title
add arginfo for all functions - drop support for PHP 4.x - add compat…
add arginfo for all functions
Sep 23, 2020
Thank you, @remicollet — I've logged this in our internal issue tracker. |
Thx.. Found a few typos in arg_info. Easy to fix. |
bpfoley
added a commit
to bpfoley/dproofreaders
that referenced
this pull request
Feb 16, 2024
It turns out the PHPStan error when analyzing this file was due to an old version of phpyaz on the dev machine. The issue appears to be incorrect metadata provided by phpyaz when using the extensions reflection API. This was fixed in phpyaz 1.2.4. See indexdata/phpyaz#11 (comment)
bpfoley
added a commit
to bpfoley/dproofreaders
that referenced
this pull request
Feb 16, 2024
It turns out the PHPStan error when analyzing external_catalog_search.php Was due to an old version of phpyaz on the dev machine. The issue appears to be incorrect metadata provided by phpyaz when using PHP's extensions reflection API. This was fixed in phpyaz 1.2.4. See indexdata/phpyaz#11 (comment) Quell some incorrect linter warnings in external_catalog_search.php exposed by this.
bpfoley
added a commit
to bpfoley/dproofreaders
that referenced
this pull request
Feb 16, 2024
It turns out the PHPStan error when analyzing external_catalog_search.php Was due to an old version of phpyaz on the dev machine. The issue appears to be incorrect metadata provided by phpyaz when using PHP's extensions reflection API. This was fixed in phpyaz 1.2.4. See indexdata/phpyaz#11 (comment) Quell some incorrect linter warnings in external_catalog_search.php exposed by this.
cpeel
pushed a commit
to DistributedProofreaders/dproofreaders
that referenced
this pull request
Feb 18, 2024
It turns out the PHPStan error when analyzing external_catalog_search.php Was due to an old version of phpyaz on the dev machine. The issue appears to be incorrect metadata provided by phpyaz when using PHP's extensions reflection API. This was fixed in phpyaz 1.2.4. See indexdata/phpyaz#11 (comment) Quell some incorrect linter warnings in external_catalog_search.php exposed by this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Careful review needed as this is quite a huge work, and a mistake is quite easy
Using PHP_VERSION : 8.0.0beta4