fix for PHP 7.3 API changes, and array_init always succeeds

[remicollet]

From UPGRADING.INTERNALS

  a. array_init() and array_init_size() are not functions anymore.
     They don't return any values.

[adamdickmeiss]

Thx

[ryandesign]

Is this the correct thing to do for PHP 7.2 and earlier? I thought you would need to check PHP_VERSION_ID and if it's less than 70300 then check the return value otherwise don't.

[adamdickmeiss]

Yep. php 7.1.25 _array_init always returns SUCCESS. So check is redundant.

ZEND_API int _array_init(zval arg, uint32_t size ZEND_FILE_LINE_DC) / {{{ */
{
ZVAL_NEW_ARR(arg);
_zend_hash_init(Z_ARRVAL_P(arg), size, ZVAL_PTR_DTOR, 0 ZEND_FILE_LINE_RELAY_CC);
return SUCCESS;
}

[ryandesign]

Ok great. I was curious, so I checked, and it used to return FAILURE in out of memory situations, but that was removed in php/php-src@87e3924 back in 2001 and since then it always returns SUCCESS. That change was included in PHP 4.1.0 and since phpyaz requires PHP 4.3.0 that should be fine. Now we just need a new release of phpyaz that contains the fix! :)

[adamdickmeiss]

Released now. Thx

…

On Mon, Dec 10, 2018 at 8:12 PM Ryan Schmidt ***@***.***> wrote: Ok great. I was curious, so I checked, and it used to return FAILURE in out of memory situations, but that was removed in ***@***.*** <php/php-src@87e3924> back in 2001 and since then it always returns SUCCESS. That change was included in PHP 4.1.0 and since phpyaz requires PHP 4.3.0 that should be fine. Now we just need a new release of phpyaz that contains the fix! :) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIJB33P7HolpRBg6kGEO1OvqesYVHewmks5u3rICgaJpZM4U5k_W> .