Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexedDBShim does not work in webworkers #219

Closed
PedroJusto opened this issue Aug 31, 2015 · 7 comments
Closed

IndexedDBShim does not work in webworkers #219

PedroJusto opened this issue Aug 31, 2015 · 7 comments

Comments

@PedroJusto
Copy link

Hi! despite of there is a workaround, your library is not prepared to be used in WebWorkers .

@JamesMessinger
Copy link
Collaborator

Can you post a code sample? Maybe on JSFiddle or Plunker?

@PedroJusto
Copy link
Author

the problem is that webworker does not have access to window object. my workaround is to define in webworker :

var window = self;
and import indexeddbshim.js with importScripts("indexeddbshim.js"); inside webworker

@brettz9
Copy link
Collaborator

brettz9 commented Jun 17, 2016

I've pushed some changes to master which should address the problem. Would someone mind testing and ideally offering a PR containing a test (and any further fixes)? Thanks!

@brettz9
Copy link
Collaborator

brettz9 commented Jun 17, 2016

And in case you already tried pulling, sorry, I realized I hadn't pushed the changes to this repo's master. Now available.

@brettz9
Copy link
Collaborator

brettz9 commented Oct 18, 2016

This should be fixed in master. I'm closing but feel free to reopen.

@brettz9 brettz9 closed this as completed Oct 18, 2016
@axemclion
Copy link
Collaborator

@brettz9 Just wanted to drop in and say thanks for the awesome work you are doing with the IndexedDBShim - I can see that it is helping a lot of people. :)

@brettz9
Copy link
Collaborator

brettz9 commented Oct 18, 2016

Thank you, @axemclion . Not sure if it is helping anyone yet, but it is encouraging to know there is eagerness for the release. Am feeling a bit better these days and on my agenda to try to get ready (as I am able) for a 3.0.0 release as per #262 (comment) . Very grateful for being able to build on such a strong foundation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants