-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo questions/issues #264
Comments
Also, Github now allows "topics" (visible at the top of the main page). It would be good for us to add the "indexeddb" topic to the repo for better discoverability. |
Agreed. Lets start with IndexeDB, WebSQl, Storage to start with ? |
Sounds good to me... Regarding the license issue--to clarify, it was in regard to the "Apache-2.0" button that shows up on the repo but which links to our MIT license instead. I tested it on my fork to see if I could get rid of it, but only deleting the Apache license got it fixed. I reported the issue just now to Github and can report back. But I would still like to know about gh-pages if there is anything you wanted to be done with it... |
@axemclion... Not sure whether you saw my comment at #262 (comment) ? We could really use an answer about a new release. Alternatively, if you don't have time to consider but trust us to go ahead, could you add me on for |
@brettz9 Sorry, my bad for falling back on this. I think you have been doing an amazing job on the repo and you should be the publisher. What should be the name of the npm package you would want to be the owner of ? |
Thanks, @axemclion . :-) I was just thinking if you could add me as an owner of the current one you have been using so I can publish to the "indexeddbshim" package so that there is no break for those users who are allowing for major version semver breaks.
(The npm docs state there is no fine grain control of permissions, so I'd end up as a co-owner with the same privileges.) If you mean you want to publish under a new package name though, of course, that would be cool too. Maybe "indexeddbpolyfill" would fit if you wanted to go that route. (My interpretation of "polyfill" is that you can use the same standard API--which fits for the default approach even better than "shim" I think.) Whatever you decide, before we publish, I need to make a clear notice to any migrating users because it will break existing storage and use of existing storage. Code could have admittedly been added to allow migration of content, but it would have been ugly, probably add a performance cost as we'd need to check existing data each time, taken quite a bit more time to implement that I didn't care to spend, and I figured as the version was a breaking one with other breaking fixes anyways, that we could afford a clean break, assuming we at least convey the changes to users.
|
Looks like I am not the owner of https://www.npmjs.com/package/indexeddbshim. @BigstickCarpet Can you please add @brettz9 as an owner on that package please ? If we don't hear from @BigstickCarpet I think you should publish a new package, as you have done most of the work, and you are probably now a more appropriate owner of the project than me. |
Ok, thanks, @axemclion . And unless there are any objections, I'll just update |
@brettz9 and @axemclion - What are your NPM account names? I'll add you both as owners of the |
Thanks, @BigstickCarpet . |
lol. I guess I should have assumed that you'd both use the same usernames for NPM as you do for GitHub. :) Anyway... you've both been added to the npm package |
Awesome, thanks! And now version 3.0.0-rc.1 is published to npm and released as a tag for Bower! (and Btw, one more question-- @axemclion -- the README and source maps are also currently pointing to http://nparashuram.com . Are you interested in having your site match our latest release? In looking for possible alternatives in case you weren't interested, unfortunately, |
@axemclion : I went ahead and made the demo tests and source maps point to http://rawgit.com (I added a Grunt routine to copy the few test files needed out of I think that having things on rawgit.com will be best as it ensures we can control everything in one place and keep it up to date. I do see you have some code at your site (the jQuery plugin) that we don't have here, but as it is no doubt out of date, so I only borrowed its stylesheet (which was expected by I think I'm satisfied now to close the issue. |
gh-pages
? Should I keep it up to date?The text was updated successfully, but these errors were encountered: