-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status for polyfilling IE / Edge? #316
Comments
Hi David, Although I am normally quite loth to make any updates containing known regressions, as per #277 , given my personal priorities not affording time for maintaining and updating the previous support the project had for compound keys, and the feeling that the other improvements and Node support made justified going ahead in a new major version in spite of this, I regrettably dropped this support in 3.0.0. The last version of the code responsible for compound keys in IE was at https://github.com/axemclion/IndexedDBShim/blob/829577ec428a210f51b5acfceeae993d2d6723dd/src/polyfill.js (with the tree at https://github.com/axemclion/IndexedDBShim/tree/829577ec428a210f51b5acfceeae993d2d6723dd ). We'd of course most welcome support being restored (ideally ensuring all of the other tests passing in other browsers, including W3C tests, would pass for IE in the version restoring support as well). Ideally, we could add this functionality to its own stand-alone module for a more suitably light-weight approach if, for example, server-side browser detection would determine the rest of the shim would not be needed. |
To get the IE / Edge compatible polyfill you need to go back to v2 as per @brettz9 comment above. That's what I've just had to do to enable IE / Edge to work properly with compound keys, but unfortunately it wasn't even that simple as although there is browser detection for IE / Edge, it's never called because poorIndexedDbSupport isn't set. If I had more time on my hands I'd offer to take up the mantle of restoring IE / Edge support to newer versions, but I can't right now. Hopefully the above will help anyone else that ends up here looking to get IE / Edge support in some shape or form. |
To provide some subjective justification and up this thread: Microsoft, as of now, requires IE11 support in their official AppSource certification policy for Office.js Excel Add-ins, primary reason being that add-in task panes for Excel on Windows still run in an IE11 tab. Unfortunately, this wasn't properly researched at the time we decided to use fancy modern browser features in our add-in :) So, if anyone has time to work on returning full IE11 support to this library, I'd buy them a beer. |
Hi! Thanks for an extreemely valuable polyfill!
I was wondering about the status of using this shim to polyfill the lack of compound- and multiEntry indexes in IE and Edge. I used to create a polyfill for that for many years ago, but my work stalled so I''ve never picked it up. Is anything of this supported, and is there any idea or plan to include that in this polyfill? Would it be better to have a separate polyfill for IE/Edge?
The text was updated successfully, but these errors were encountered: