Implemented @glennjones "innerText" parsing for better parsed whitespace #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock level elements and whitespace.
Updated test ParserTest::testAreaTag() with what I believe is the correct assertion.
|
r+ on code changes. Thanks for this! |
aaronpk
added a commit
that referenced
this pull request
Feb 29, 2016
Implemented @glennjones "innerText" parsing for better parsed whitespace
|
Thanks also for the comment grammar corrections ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #69 and most cases like it. I added this as a separate, recursive method
innerText()because I wasn't sure about unintended consequences of trying to expand thetextContent()method, used in multiple places.Also updated test
ParserTest::testAreaTag()with what I believe is the correct assertion. Previously it asserted the parsed name would be blank, but it currently (correctly, I believe) parses "Person Bee"Test
UrlTest::testReturnsUrlIfAbsolutecontinues to fail as before; unrelated to this PR.