Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Revoke all refresh tokens for a client #577

Open
hshort opened this issue Feb 27, 2023 · 4 comments
Open

FR: Revoke all refresh tokens for a client #577

hshort opened this issue Feb 27, 2023 · 4 comments

Comments

@hshort
Copy link

hshort commented Feb 27, 2023

Feature request :)

In the case of a security incident we would need to revoke all refresh tokens for a client.

Some users may wish to revoke access tokens as well (though revocation of access tokens is obviously up for debate...)

@norealroots
Copy link
Contributor

Also useful should a client accidentally make way too many infinitely lived refresh tokens...

Definitely not from experience or anything.

@enricovianello enricovianello added this to the General backlog milestone Mar 2, 2023
@federicaagostini
Copy link
Contributor

The "Disable client" feature included in v1.9.0 (#747) with the following impossibility to obtain access/refresh tokens should solve this issue. Please open it again if the PR does not satisfy this issue.

@giacomini
Copy link
Contributor

We've discussed a bit internally and we re-open the issue, because suspending a client doesn't necessarily mean that all refresh tokens need to be revoked. The meaning of suspension can be discussed elsewhere (unless it coincides with this request), but what is the exact meaning of this FR? Are we talking about refresh tokens or more in general about consents? do we want to allow to revoke all RTs/consents or also to give the possibility to revoke a selection of them?

@giacomini giacomini reopened this Jul 23, 2024
@hshort
Copy link
Author

hshort commented Jul 23, 2024

Hi - I agree the two things could be separate. This request (in my understanding) was to cover cases such as

  • A client secret is compromised
  • Refresh tokens are issued to the compromised client
  • We find out, change the client secret and secure the client
  • Any refresh tokens issued whilst the client was compromised should no longer be valid
    So what we might want is a way to revoke RTs in a particular time frame. Honestly I'm not sure how consents come into the picture.
    Is that any clearer?
    Thanks,
    Hannah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants