-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poetry install --with dev
doesn't install pre-commit hooks
#23
Comments
I have created script.py for this. I thought it was getting installed from here.
|
For me I had to do |
Maybe this is something you could take a look at, though I agree that using something native to poetry would be better than using extensions: https://pypi.org/project/poetry-pre-commit-plugin/ |
From what I can tell the import subprocess
def post_install() -> None:
with open("test.txt", "w") as f:
f.write("this function ran")
subprocess.run(["poetry", "run", "pre-commit", "install"], check=True) And no file is created when running poetry install. |
From what I can tell the [tool.poetry.scripts] option is actually for making cli scripts, so basically it lets you register a command for the cli. So what the
|
I found this post by the creator of poetry and he says he doesn't support running scripts on installation, so its probably best to just have to person contributing run the pre-commit commands manually, or to use the extension I sent earlier (although it looks like you can't install the push hook automatically through the extension) |
Running
poetry install --with dev
doesn't install the pre-commit hooks, as of right now they need to be installed manually throughpre-commit install
The text was updated successfully, but these errors were encountered: