api: fallback to anonymous function #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Now the second step is to detect whether we are running in environment without |
alex7kom
changed the title
|
How about this? |
|
Yay! Exactly! |
| '})'); | ||
| var named; | ||
| try { | ||
| named = require('vm').runInThisContext('(function ' + this.name + '(entity) {\n' + |
There was a problem hiding this comment.
May I ask you to preserve the 80 column limit that I had here? ;)
|
Just one minor nit, otherwise LGTM! Thank you! |
|
(Assuming it works for you ;) ) |
`vm-browserify` uses `eval()` which is disabled in Chrome Apps (completely) and Extensions (by default CSP). If can't execute `vm.runInThisContext` to create named function, fallback to unnamed function expression.
|
Done! Yes, it does work for me, with just an uh-oh scary warning in the Chrome console:
|
|
Thank you! Landed and released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vm-browserifyuseseval()which is disabled in Chrome Apps (completely)and Extensions (by default CSP). If can't execute
vm.runInThisContextto create named function, fallback to unnamed function expression.