Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes - isPrivate and isPublic now throws #146

Open
Cheprer opened this issue Feb 22, 2024 · 1 comment
Open

Breaking changes - isPrivate and isPublic now throws #146

Cheprer opened this issue Feb 22, 2024 · 1 comment

Comments

@Cheprer
Copy link

Cheprer commented Feb 22, 2024

Breaking change should be mentioned in changes please somewhere.

Now it throws when it is invalid and needs to be handled in try catch for example.

Throws -> invalid ipv4 address

We have handled it, but bumps in dependabot can be tricky for someone so just mentioning it here for others.

@Cheprer Cheprer changed the title Breaking change for isPrivate and isPublic Breaking changes - isPrivate and isPublic now throws Feb 22, 2024
@mixmix
Copy link

mixmix commented Feb 29, 2024

in v1.1.9:

> ip.isPrivate('dog.com')
Uncaught Error: invalid ipv4 address
    at ip.isPrivate (~/projects/node-ip/lib/ip.js:323:13)

This is a change in behaviour from 1.1.8:

> ip.isPrivate('dog.com')
false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants