Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore: Buble integration #36

Closed
lukeed opened this issue Jan 6, 2017 · 11 comments
Closed

Explore: Buble integration #36

lukeed opened this issue Jan 6, 2017 · 11 comments

Comments

@lukeed
Copy link
Member

lukeed commented Jan 6, 2017

This plugin is the only reason I'm still using Babel. Perhaps that's a way to hook into Buble's JSX system?

@Havunen
Copy link
Member

Havunen commented Jan 6, 2017

Lets create repository under infernojs organization

@lukeed
Copy link
Member Author

lukeed commented Jan 6, 2017

@Havunen Yes, but I'm still not sure if this is even possible yet.

@Havunen
Copy link
Member

Havunen commented Jan 6, 2017

we can ping rich-harris at slack regarding this. I think he will be happy to give some pointers to get started.

@TrySound
Copy link

TrySound commented Mar 1, 2017

@lukeed
It's simple but you should use inferno-create-element instead. There's jsx option in buble which accepts a factory expression like React.createElement or just createElement.

Cons: it does not support spread props

@Havunen
Copy link
Member

Havunen commented Mar 1, 2017

Sadly inferno-create-element cant achieve same performance as createVNode :(

@TrySound
Copy link

TrySound commented Mar 1, 2017

Is everything so bad? Then you can always fork buble as usual. :)

@lukeed
Copy link
Member Author

lukeed commented Mar 1, 2017

Thanks, I'm aware but it's not what I'm after. Just trying to port an equivalent plugin to buble.

@Havunen
Copy link
Member

Havunen commented Mar 26, 2017

Typescript plugin might be possible in next 2.3 release:
microsoft/TypeScript#13940

@chee
Copy link

chee commented Mar 30, 2017

seems to work with inferno-hyperscript and buble --jsx h

@lukeed
Copy link
Member Author

lukeed commented Mar 30, 2017

@chee Yes, that's supposed to work. But most Inferno users don't use the hyperscript-plugin.

@Havunen
Copy link
Member

Havunen commented Feb 11, 2018

Lets close this issue. We could implement it for buble If they start supporting plugins. Also new features are coming to JSX in babel7, Fe: Fragments those should be done first.

@Havunen Havunen closed this as completed Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants