Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

innerref problem (again in server rendering) #1523

Closed
simonjoom opened this issue Sep 16, 2020 · 4 comments
Closed

innerref problem (again in server rendering) #1523

simonjoom opened this issue Sep 16, 2020 · 4 comments

Comments

@simonjoom
Copy link

#1486

the issue i mentioned on the link upper reappear for react server rendering on the last version
i ve got type is not a function again

i did a quickfix in rendertostring around line 69

const renderOutput = type.render?type.render(props, context):type(props, context);
//const renderOutput = type(props, context);
            if (isInvalid(renderOutput)) {
                return '<!--!-->';
            }
            if (isString(renderOutput)) {
                return escapeText(renderOutput);
            }
            if (isNumber(renderOutput)) {
                return renderOutput + '';
            }

@Havunen
Copy link
Member

Havunen commented Sep 16, 2020

Thanks for reporting this issue. Would you like to send PR to fix it or implement a test case to reproduce it easily? :)

@simonjoom
Copy link
Author

to reference my last issue for more details:
#1486

you already resolved that in client side (i did not noticed the problem)
for fast fix just add the conditionnal type.render? like i did, else type is not a function can occur again.

i just used your inferno server rendering version working with fragment and it's work now !
thanks you (before i used react server rendering as inferno did not support it)

@Havunen
Copy link
Member

Havunen commented Sep 19, 2020

This issue is now fixed in: fb6570c
It will be available in v7.4.5

@Havunen Havunen closed this as completed Sep 19, 2020
@simonjoom
Copy link
Author

Yes i confirm, it's working now. yeah it was from inneref thks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants