-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch v5.0.x to get rid of opencollective runtime dependency #1532
Comments
Yeah, I believe that can be done :) Btw. What is the main reason to not being able to move to v7? We have fixed many issues in the latest versions |
Thanks for the quick answer! Really appreciate it. The reason we can't currently update inferno is that it would break any We don't have an easy migration path currently that would make it easier for those extensions to migrate (cf. bpmn-io/dmn-js#394) |
cant you update to v5.6.1 ? I don't think it makes much sense of inferno to release patch to some very old minor version? Just by browsing through release notes I dont see any breaking change between 5.0.6 - 5.6.1 |
Would this solve the |
I would like to release patch to 5.6.1 to fix latest v5 version of infernojs to change that dependency rather than fix some old minor version |
We will check whether an update to |
Good news 📣 We were able to upgrade our inferno version to |
Okay v5.6.2 is available now, without opencollective dependency. https://github.com/infernojs/inferno/releases/tag/v5.6.2 |
Thanks a lot! |
Hi 👋🏻
I saw that the inferno package replaced
opencollective
withopencollective-postinstall
to get rid of many dependencies (cf. #1450). Due to different reasons, we are sticking to thev5.0.x
version of theinferno
package in ourdmn-js
project, so we can't receive this update since the fix is not backported to the latestv5.0.6
in this minor range.However, we recently got notifications that projects using our libraries receive security vulnerability warnings (cf. bpmn-io/dmn-js#609). These are caused by the fact
inferno@5.0.6
is still using the outdatedopencollective
dependency. Since we can't currently upgrade inferno to the latest versions, we would need a patched version ofv5.0.x
to solve this problem.I created a branch that already backports the fix to
v5.0.6
: https://github.com/infernojs/inferno/compare/v5.0.6...pinussilvestrus:patch-5.0.x?expand=1Would it be possible to release those changes under a new
inferno@v5.0.x
patch version? We would be very thankful if you could support us with that!The text was updated successfully, but these errors were encountered: