Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimize monitor data fetching for large time ranges #5

Merged
merged 7 commits into from
Dec 6, 2024
Merged

fix: optimize monitor data fetching for large time ranges #5

merged 7 commits into from
Dec 6, 2024

Conversation

yaojp123
Copy link
Contributor

@yaojp123 yaojp123 commented Dec 6, 2024 •
edited by luohoufu
Loading

What does this PR do

  1. fetch data independently in every chart)
  2. lazy render
  3. add actions (copy dsl, refresh) to every chart
  4. add timeout to datepicker

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Performance tests checked, no obvious performance degradation
  • Necessary documents have been added if this is a new feature

@luohoufu luohoufu self-requested a review December 6, 2024 04:08
@luohoufu luohoufu changed the title fix: can not fetch data in monitor if data is large fix: optimize monitor data fetching for large time ranges Dec 6, 2024
luohoufu
luohoufu approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@luohoufu luohoufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

medcl
medcl reviewed Dec 6, 2024
View reviewed changes
web/src/locales/en-US/cluster.js Outdated
@@ -347,4 +347,7 @@ export default {
"cluster.providers.aliyun": "Aliyun",
"cluster.providers.tencent-cloud": "Tencent-cloud",
"cluster.providers.ecloud": "Ecloud",

"cluster.metrics.dsl.copy": "Copy DSL",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to use request reather dsl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@medcl medcl merged commit d6a8e2f into main Dec 6, 2024
2 of 3 checks passed
@medcl medcl deleted the fix-monitor branch December 6, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medcl medcl medcl left review comments

@luohoufu luohoufu luohoufu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaojp123 @medcl @luohoufu